okfde / froide

Freedom Of Information Portal
MIT License
366 stars 87 forks source link

Redaction issue in email text #212

Closed arnese closed 6 years ago

arnese commented 7 years ago

When names and text elements are deleted from "Redacted text" area, this blackens the area, but still makes it possible to copy the text from area. Only when text is replaced by other text this doesn't happen.

fin commented 7 years ago

huh, 2 years ago (the version we're running on .at cough), redaction was implemented by creating an image pdf. has this changed?

arnese commented 7 years ago

Nope. Should have specified: This is about redaction in text of emails, not in attachments.

GiantCrocodile commented 7 years ago

I expected this but I don't feel like this should be changed. I dislike how hard it is to read redacted text sometimes but changing the copy feature - well please not. I often need to copy data which is redacted because I need it for e-mails or forwarding or internal resources so I would have to copy the text by hand.

fin commented 7 years ago

this only happens when you're logged in (on your own requests), or when you're logged in as admin (maybe?).

try this in an incognito window: https://fragdenstaat.de/anfrage/weisungen-des-jobcenters-jobcenter-landkreis-amberg-sulzbach-und-die-stadt-amberg/

arnese commented 7 years ago

Hm, not really. Happens when I manually delete text so it becomes redacted, not with the automatic redactions. But it's all a bit unclear, because I cannot always reproduce it either.

https://fragdenstaat.de/anfrage/weisungen-des-jobcenters-jobcenter-landkreis-amberg-sulzbach-und-die-stadt-amberg/#nachricht-65210 In your request, for example I manually deleted the word "Paris" from the line "Die Adresse in Paris ist die aktuell gültige". Now more is redacted, while the text behind it can still be copied (but not "Paris", actually)

fin commented 7 years ago

oh right, mea culpa. (better restore that word though, not my request ;) )

stefanw commented 7 years ago

The 'algorithm' behind the redaction effect is a monster based on Python's SequenceMatcher. Probably needs a more human text (not code) centric diffing library (not 100% that is the problem though).

arnese commented 6 years ago

This particular case is solved by now.