okfde / froide

Freedom Of Information Portal
MIT License
367 stars 87 forks source link

Text redaction problems for long texts #443

Closed rugk closed 3 years ago

rugk commented 3 years ago

If you copy and paste your 5 pages long FOI appeal into the Froide, the text redaction seems to get a problem:

See here: https://fragdenstaat.de/anfrage/sap-cwa-jira-tickets-zu-den-themen-f-droid-vollkommen-quelloffener-software-und-reproduzierbare-builds-corona-warn-app/#nachricht-592041

This is how it publicly looks like:

Here is what – in the private view – the redaction tool, shows me:

Edit:Also, BTW, when you change the text and edit it, all your redactions are gone – which is, while technically understandable for me – likely a surprising thing for many users. Or at least some unfortunate thing…

stefanw commented 3 years ago

We introduced cached rendering for long messages recently, because determining redactions can be CPU heavy for long texts. Cache invalidation was broken here, should be fixed now. Cache has been invalidated for all edited/redacted messages since the introduction of redaction render caching.