okfde / froide

Freedom Of Information Portal
MIT License
357 stars 86 forks source link

Show button to edit attachments ("Anhänge verwalten") also when there are no attachments #460

Closed rugk closed 2 years ago

rugk commented 3 years ago

Problem

  1. I added a "mail received" ("Post erhalten") mail entry to a FOI request. Do not add any documents and just always press "Continue". The use case here may be that you've got 500 pages of a mail and want to scan it in later, because that's way too much work. As such, you only want to document that you've got the results.
  2. Now, on the main request page again, try to add these documents, after you've scanned them.

What happens: You find no button to do so. UI-wise, you can only edit or add attachments, if you've initially added at least once. Even for letters.

Workaround

You can manually adjust the URL to get to the website for uploading.

Go to the message via the sidebar or so, so you get a direct link like this: https://fragdenstaat.de/anfrage/weisung-des-bmi-betreffend-uberprufung-der-luca-app-2/#nachricht-634277

Now use the number at the end to form the following URL: https://fragdenstaat.de/anfrage/weisung-des-bmi-betreffend-uberprufung-der-luca-app-2/634277/upload

That's it, there is the upload form.

Suggested solution

Do show the button to edit attachments always? At least when the type is a letter, IMHO, it is more than appropriate.

Alternative solutions

Require people to upload an attachment when attaching a letter? -> IMHO prevents the legitimate use case I outlined above.

alehaa commented 3 years ago

I'd like to add, that if there's already an attachment uploaded, the upload page doesn't have a button to add new attachments, just to manage existing ones.

rugk commented 3 years ago

@alehaa There should be a drag- and drop zone including an optional "legacy" file-selctor behind the link for that at the bottom: image

In my case, that is always there.

alehaa commented 3 years ago

Not in Safari. Maybe this feature is browser specific?

screenshot

pajowu commented 2 years ago

@alehaa the upload form is not shown on this foi request because it is only shown on answers received via (snail) mail

stefanw commented 2 years ago

https://github.com/okfde/froide/commit/e66aec0dff966a887a029311e5e848a4f01a8934 should solve the problem.