🐛 Fix facets being lost in pagination

okfde / froide

Freedom Of Information Portal

MIT License

356 stars 86 forks source link

🐛 Fix facets being lost in pagination #688

Closed pajowu closed 1 year ago

pajowu commented 1 year ago

Fixes #687 Fixes #682

pajowu commented 1 year ago

Note: This also fixes a previously unreported bug where the jurisdiction path filter no longer applied if a status path filter was set too by switching from re_paths to a custom converter for the status path field.

stefanw commented 1 year ago

I fixed two things:

the status URL converter is nice but does not allow for translatable status slugs. This was broken before as well, but maybe it's time to fix it.
facet are now filtered so all facet links return results

Great work on the tests, they helped a lot!