Closed guilhermebr closed 7 years ago
Hi @guilhermebr — we already have a PR opened for #205. It's the PR #207 we're just holding back because testing thing is production/staging is not feasible until we finish #245. So, once #245 I'll go back to #207 and your PR.
Meanwhile any comments on what #207 missed that you're covering here?
@cuducos Sorry, actually I missed this opened PR. I saw that last issue message was on Jul 21 and thought that it's an abandoned issue. My fault.
I will close the PR and comment in the opened PR.
By the way, if you need any help in #245 let me know.
Thanks
By the way, if you need any help in #245 let me know.
That'd be awesome. The PR is kind of ready for code review I guess and @anaschwendler and @lipemorais are testing it. The opening post suggest some simple tests to make sure development and production environments. @lipemorais also raised some interesting questions on having two or three config files… if that is your field of expertise we'd really appreciate having your opinion there ; )
This PR solves #205
Changes based on https://gist.github.com/plentz/6737338