search

okfn-brasil / jarbas

🎩 API for information and suspicions about reimbursements by Brazilian congresspeople
https://jarbas.serenata.ai/
296 stars 61 forks source link

Update to Django 2.0 #311

Open anapaulagomes opened 6 years ago

anapaulagomes commented 6 years ago

This PR solves #296. To check which warnings should be fixed I ran python -Wall manage.py test. Since we have some dependencies (at this point, just django-simple-history), I updated the libraries locally to make sure the changes are working and the tests are passing.

Since it's my first time contributing to Jarbas, it was a good way to know more about the code. :) I wasn't expecting to touch so many parts.

How to test if it really works? Making sure the tests are passing. Question: should I do any manual tests? I ran it on my machine but I just played around.

TODO

cuducos commented 6 years ago

Hi @anapaulagomes – thanks for this awesome PR!

While django-simple-history has no update I wish to share a worry with you all: we're already using a fork of this package because of the lack of updates from the maintainers. Last year we tried to get more maintainers involved but for whatever reason the package has no updates in the last 8 months.

That said, we might track for forks that might be already updated for Django 2.0 and merge them to the branch we're using (this branch has some new lines to enhance i18n). I'm not confident the official repo will be updated soon – and I might be terribly wrong.

TLDR A nice way to contribute with Jarbas is to fork and update django-simple-history hahaha…

anapaulagomes commented 6 years ago

I saw the last comments on https://github.com/treyhunner/django-simple-history/pull/320 and it seems people are working on it. The last update was in November. Does your fork have different features (just trying to understand better)? I can work on the Django 2.0 update for your fork, no problem (I guess :P ).

cuducos commented 6 years ago

it seems people are working on it

Great news then 🎉 Sorry about my skepticism/pessimism about it.

The last update was in November

The last update on the repo was in November. But that last relase was in June (source: GitHub and PyPI). However if we're installing from GitHub, I prefer to keep my barely untouched fork than risking installing a master from other repo that eventually might include some breaking changes.

Does your fork have different features (just trying to understand better)?

Just a single, but relevant, commit improving translations (that we use in Jarbas UI). This commit is already in their master branch, but was not included in the latest PyPI release.