search

okfn-brasil / mosaico

Visualization on the brazilian budget for FGV
GNU Affero General Public License v3.0
5 stars 0 forks source link

What to do when the treemap's amount is zero? #36

Open vitorbaptista opened 11 years ago

vitorbaptista commented 11 years ago

For example, in http://weiss-staging.herokuapp.com/#/treemap/2013/13-cultura/422-direitos-individuais-coletivos-e-difusos

ltartari commented 11 years ago

How did you get to this, @vitorbaptista ?

I see only one way you could possible get to this page: after seeing it in one year with a positive value, you change the year to where it doesn't have anything. In that case, should the year be displayed at all? IMHO that's the question. : )

vitorbaptista commented 11 years ago

You need to go to http://weiss-staging.herokuapp.com/#/treemap/2012/13-cultura and click in "Direitos Individuais e Coletivos Difusos". Then you can change the year to 2013.

Yes, if there's no data for a certain year, it won't appear in the list (just fixed that). The problem is that there IS data for this year, but it's zero. Check http://openspending.org/api/2/aggregate?cut=funcao%3A13%7Csubfuncao%3A422&dataset=orcamento_publico&drilldown=year

Maybe filter out years that have no data OR that have amount 0? That feels a bit odd, because there is data for that year for that cut, it just didn't had an authorized amount. Maybe, when we add the table, we'll see the other pago/rppago values.

ltartari commented 11 years ago

IMO there should be no way to "see" a Treemap with 0 as the value, @vitorbaptista

If there's an entity (or whatever we're calling it =P) listed on the data-grid it should NOT be a link ;-)

ltartari commented 11 years ago

So, after a quick Skype chat we have decided that the Treemap will NOT be shown for values equal to 0. On his place a text saying "Não há valores para NOMEDOCORTE" (or something similar) will be displayed.

NOTE: There will be no background color for this message, making it not an "empty Treemap" but just a notice instead.