okfn-brasil / perfil-politico-frontend

Front-end that consumes Perfil Político's API
https://perfilpolitico.serenata.ai
GNU General Public License v3.0
31 stars 25 forks source link

Adding ESLint, Prettier and CircleCI Support #13

Closed gvarandas closed 5 years ago

gvarandas commented 5 years ago

Problem

The project currently did not have any way to guarantee the coding standard and best practices. This is being discussed in issue #3.

Solution

The integration of some tooling to help the developers to keep their attention where its needed: solving problems.

Steps

Continuous Integration

Even though there is a CircleCI configuration file, the integration to the external tool must be done by the owner of the project.

The config steps are detailed here.

Also, CircleCI supports open source projects by allowing multiple containers to run the build jobs and it is also possible to configure which branches should trigger the CI (or even if PRs should also do it).

The Open Source configurations are here and I can also help with that if needed.

cuducos commented 5 years ago

Even though there is a CircleCI configuration file, the integration to the external tool must be done by the owner of the project.

Just added the repo to Circle CI and it's working for this PR already (failing though). Gonna take a look a better later, but anyone feel free to jump in.

gvarandas commented 5 years ago

Just updated the PR with the no-unused-vars exception. This is necessary due to the usage of the global namespace. Im planning to submit a PR next to also refactor this (and remove the exceptions).

cuducos commented 5 years ago

Awesome, many thanks, @gvarandas ; )