Add gender support to hardcoded strings

[guidiego]

I followed some @cuducos instruction on issue #6 and add gender support to a hardcoded part! I inserted the translation inside the same file of the code, maybe we could improve it later :) Let me know if have any other part that I can act before this PR be merged :D

[cuducos]

Hi @guidiego,

Many thanks for this contribution! I think this was a cleaver way to fix #6.

As you've pointed out, I do think we should keep the dictionary of male/female words somewhere else (maybe a new file at perfil-politico-frontend/src/js/data/, maybe remember one of the files within this directory to be more generic).

Also I was wondering if we could wait for more contributions in this branch so we have more terms fixed according to the gender. I think there only one or two more occurrences.

What do you all think about that?

[guidiego]

@cuducos I totally agree! I think that we could create a new file, yesterday I thought in use one of both already existing, but I reconsidered it, I remembered that we aren't translating anything to put it inside one of them, In my vision will be more clear if we create a file called: alternative-labels.js or something like that.

Could you point the other cases? I will jump on it today to help the project!

[cuducos]

• Next to the candidate picture there's a Já foi eleito?
• In the Histórico de candidaturas chart there's the job title (e.g. Deputado Federal instead of Deputada Federal) and, if the person was already elected, Eleito instead of Eleita (including Nao Eleito and Eleito por QP, for example)

I think that's all. Have you noticed anything else, @anarute?

[anarute]

Nice, great approach! That's all the places I've noticed too.

[gvarandas]

@guidiego there are some conflicts with the master branch. Could you investigate, please?

[guidiego]

Yeah @gvarandas ley me check it right now!

[guidiego]

@cuducos @gvarandas I think that I finished this one :)

[cuducos]

Awesome, thank you both <3