search

okfn-brasil / perfil-politico-frontend

Este repositório não está recebendo atualizações | Front-end that consumes Perfil Político's API
https://perfilpolitico.serenata.ai
GNU General Public License v3.0
31 stars 25 forks source link

Use HTML template engine #21

Closed cuducos closed 6 years ago

cuducos commented 6 years ago

We have repeated snippets of code in our three HTML pages (index.html, sobre.html and faq.html). The DRY philosophy invites use includes to avoid this repetition and enhance maintainability.

siddhant-soni commented 6 years ago

hey, I would like to take this up

cuducos commented 6 years ago

hey, I would like to take this up

Go for it ; ) The idea is to avoid repetition such as #22

siddhant-soni commented 6 years ago

Alright! Is there a particular engine that you want to use?

cuducos commented 6 years ago

No, nothing specific in mind.

guidiego commented 6 years ago

If I could suggest: Handlebars is a nice pick for it! We can do many kinds of helpers in this project :D

siddhant-soni commented 6 years ago

@guidiego thanks for the suggestion, I'll have a look

gvarandas commented 6 years ago

Also, html-webpack-plugin works very well with HTML templates. I'd recommend to check it out for integration with the build process.

siddhant-soni commented 6 years ago

@gvarandas Thank you for the suggestion, but I have already done it with Handlebars. Please have a look, I would appreciate any feedback.