Closed siddhant-soni closed 5 years ago
@siddhant-soni nice job! 🏅
Just one feedback: some attributes on the head template, like og:title
and og:url
are different, based on the page that it was put on.
The template now does not differentiate those, so this should be configurable on the head template.
Welp! On it
One last thing (I guess):
Your Google Tag Manager template google-analytics.hbs
has some formatting problems, which are causing some errors in the console.
Checked them out here and discovered that they are being caused by the quote marks you used on your code.
Test this block instead of the original and check if it solves the issue:
<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id=UA-127076320-1"></script>
<script>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag("js", new Date());
gtag("config", "UA-127076320-1");
</script>
You should see no errors in the console whatsoever. 😄
Thank you! It worked. I'll make sure to check the console every time now.
That's great : ) Many thanks @siddhant-soni for the PR and @gvarandas for the code review!
fixes #21