okfn-brasil / querido-diario-toolbox

Este projeto empodera quem deseja processar dados no contexto do Querido Diário e realizar suas próprias análises.
MIT License
32 stars 13 forks source link

Style Guidelines #5

Open aassumpcao opened 4 years ago

aassumpcao commented 4 years ago

Write up style guidelines.

jvanz commented 4 years ago

We definetly shoud write one. My first idea is to follow the standard for the python community. We should also need a tool to do the heavy work for us. I'm happy with black that we already use in the other repositories. I would be great have an easy to use command to format the code for us.

cuducos commented 3 years ago

+1 for Black

I'd also suggest isort, flake8 and mypy (as I have seen some type hints around).

I can prepare a PR with some automations on that sense if this helps : )

ogecece commented 3 years ago

Trabalhei um pouco nisso :)

Adicionei o isort, flake8 e black no projeto com ab92731 e 40d2c15. E sugeri a adição do check no CI com #40 !

Acho que o mypy seria uma boa também! Pode ficar à vontade @cuducos :)


English

Worked a bit on this :)

Just added isort, flake8 and black in the project with ab92731 and 40d2c15. And suggested the addition of a CI check with #40.

I think mypy would be a good idea too! Make yourself comfortable @cuducos :)