anaschwendler
commented
6 years ago Since we've developed this togheter, I'll test the branch and show the results:
-
Clone the project:
$ git clone git@github.com:datasciencebr/rosie.git -
Change to rosie's folder:
$ cd rosie -
Change to cuducos branch:
$ git fetch origin $ git checkout -b cuducos_enhance_irregular_companies_tests origin/cuducos_enhance_irregular_companies_tests $ git merge master -
Run the tests:
$ docker run --rm -v /tmp/serenata-data:/tmp/serenata-data datasciencebr/rosie test
The result:
âžś rosie git:(cuducos_enhance_irregular_companies_tests) docker run --rm -v /tmp/serenata-data:/tmp/serenata-data datasciencebr/rosie test
Unable to find image 'datasciencebr/rosie:latest' locally
latest: Pulling from datasciencebr/rosie
1160f4abea84: Pull complete
ce5807750435: Pull complete
bde36093b460: Pull complete
fdc0c7d00fec: Pull complete
cea32a557820: Pull complete
43ce03803b87: Pull complete
152d8f5011ff: Pull complete
Digest: sha256:c6cfabe62856276fee3e95561089bd6e983177189dc50136af71f09cb1fff531
Status: Downloaded newer image for datasciencebr/rosie:latest
.................................................................
----------------------------------------------------------------------
Ran 65 tests in 2.947s
OKI'll change some tests and test again to see it failing, but dor now, working good :)
What is the purpose of this Pull Request?
Extending #108 this PR addresses #106: a refactor of the irregular companies classifier to let it clearer.
What was done to achieve this purpose?
Basically using an code architecture that reflects the abstractions used for this case, that is to say, avoid sequences without meaningful labels, organizing data structure with types that allow meaningful attribution and employment of objects and variables…
How to test if it really works?
Just run the tests and this should work fine; playing around to see tests failing when they should is a good option too.
Who can help reviewing it?
@anaschwendler