okfn-brasil / rosie

🤖 Python application responsible for Serenata de Amor's intelligence
409 stars 60 forks source link

Made irregular companies classifier tests more explicit #79

Closed rennerocha closed 7 years ago

rennerocha commented 7 years ago

We have few test cases in the related fixture, so it could be better to have these tests more explicit on their objectives, avoiding the developer to navigate between two files to understand the test.

As the test file remains smaller than 100 lines I believe we can remove the fixture.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 20f0643dd169e2440bdebeb0f0ba79c9e03aaf09 on rennerocha:renne-irregular-companies-test into on datasciencebr:master.

anaschwendler commented 7 years ago

Hi @rennerocha I was testing your PR and got lost for a while, sorry for that.

So, first I'll fix issue #63 to better run the project, and then get back to you PR, sorry for not testing it yet, soon I'll be back with news!

cuducos commented 7 years ago

Any chance we follow the structure put forward by #78 here? We could add in the fixture the expected result. This sounds pretty cleaver, readable, maintainable and useful ; )

anaschwendler commented 7 years ago

I'll work on that now @cuducos 🎉