okfn-brasil / rosie

🤖 Python application responsible for Serenata de Amor's intelligence
409 stars 60 forks source link

Possible error detecting invalid CNPJ #93

Open josircg opened 7 years ago

josircg commented 7 years ago

Algorithm is considering suspect record for CNPJ that is cancelled but when the document was submitted company was still active. Example:

https://jarbas.serenatadeamor.org/#/documentId/5061168

Suggestion: we should toogle suspicion just if "Data da despesa" is greater than Company "Data situação"

anaschwendler commented 7 years ago

Hi @josircg thanks for your suggestions, it is a great time for that! @lipemorais is working in refactoring the scripts right now and we can consider that, what do you think @lipemorais, maybe collaborate on that ?