search

okfn-brasil / serenata-notebooks

Notebooks from Operação Serenata de Amor | ** Este repositório não recebe atualizações frequentes **
MIT License
53 stars 12 forks source link

Write docker-compose file #17

Closed jtemporal closed 5 years ago

jtemporal commented 5 years ago

What is the problem?

The docker command to run jupyter server isn't very friendly. Maybe write a docker-compose too and give that option would be better.

How can this be addressed?

Checkout the docker-compose documentatiomn

Who could help with this issue?

me o/

thiagoalmeidasa commented 5 years ago

Hey, on this docker-compose is better to make a local build or to use the pre-built docker image from docker hub?

jtemporal commented 5 years ago

the idea is to use the okbr/serenata-notebooks image :wink:

thiagoalmeidasa commented 5 years ago

Thanks for letting me know.

Is there any reason for us to use continuum/miniconda3 as base image instead of some more specific jupyter image like any of jupyter-docker-stacks ?

jtemporal commented 5 years ago

@thiagoalmeidasa because the jupyter ones were very heavy, the miniconda one gives an image with half the weight :wink:

jinnabaalu commented 5 years ago

can i start working on dockerising this and docker-compose.yml. is this ticket closed

jtemporal commented 5 years ago

Hi @JinnaBalu @thiagoalmeidasa has already started working on that at #18 maybe you can step over there and help giving feedback? that would be awesome :wink:

jinnabaalu commented 5 years ago

Hi @jtemporal , I can write docker-compose and instruction for dockerisation. I see the codebase dependent deployment. If you allow me i can start on that, merge @thiagoalmeidasa changes so that i can start or. or i can start without depending on @thiagoalmeidasa chnages.

jtemporal commented 5 years ago

@JinnaBalu go ahead, just keep in mind that we already have an image on docker hub to facilitate things and it would be awesome if it was a better one :smile:

looking forward to this PR

jinnabaalu commented 5 years ago

@jtemporal Created the PR https://github.com/okfn-brasil/notebooks/pull/20

jtemporal commented 5 years ago

I'm closing this one because docker compose file and necessary documentation was created... I believe further discussions should be carried out in a new issue ;)

thank you all