search

okfn-brasil / serenata-notebooks

Notebooks from Operação Serenata de Amor | ** Este repositório não recebe atualizações frequentes **
MIT License
53 stars 12 forks source link

docker-compose and docker image creation steps in README #20

Closed jinnabaalu closed 5 years ago

jinnabaalu commented 5 years ago

This is just a template to help you make your point clear with this PR. :)

What is the purpose of this Pull Request?

Tell here how this can help this project

What was done to achieve this purpose?

Explain what was done to make it work

How to test if it really works?

Write how could it be tested and checked here

Who can help reviewing it?

Who are the best people to help reviews it?

TODO

Here goes the todo list with some missing step to complete it

jinnabaalu commented 5 years ago

@willianpaixao resolved all your comments please check

cuducos commented 5 years ago

IMHO I don't think that deploying, neither considering production and local deploys, are a good fit for this repo. The idea is to be simple and extremely beginner friendly. I don't see the need to deploy it i production, just the need to make it easy for people to run it locally… what do you all think about this language options?

Users shouldn't bother about deploying, registry, release version and so on… and this sounds like noise in this context in which running "educational" notebooks should be the main focus…

jinnabaalu commented 5 years ago

Begineer also need to understand how he can take his changes to production.

cuducos commented 5 years ago

Begineer also need to understand how he can take his changes to production.

But this is not a project that goes to production anywhere…

jinnabaalu commented 5 years ago

Making beginners to understand the best practices of the production.

jtemporal commented 5 years ago

Making beginners to understand the best practices of the production

I disagree with this approach, I think the focus here is not to teach beginners about production environment but rather to teach about data analysis and data science.

that being said... Wouldn't merge this.

jtemporal commented 5 years ago

I'm closing this since I think this is taking this repo to a direction which isn't the focus, if anyone else think differently we can talk about that in a issue :wink: