search

okfn-brasil / serenata-notebooks

Notebooks from Operação Serenata de Amor | ** Este repositório não recebe atualizações frequentes **
MIT License
53 stars 12 forks source link

Update Docker-compose to pull pre-existing image #21

Closed jtemporal closed 5 years ago

jtemporal commented 5 years ago

What is the problem?

Our docker-compose.yml build the image locally, but there's a pre-built image on docker hub for this project as you can see here

How can this be addressed?

change the line 7 on the docker-compose.yml, instead of build: . use the image key like: 

image: okbr/serenata-notebooks

Who could help with this issue?

me o/

darellkoh commented 5 years ago

@jtemporal I'd love to take this issue!

jtemporal commented 5 years ago

go ahead @darellkoh all yours :+1:

darellkoh commented 5 years ago

@jtemporal Thanks! I'll have a PR ready shortly.

jinnabaalu commented 5 years ago

@jtemporal Added PR check https://github.com/okfn-brasil/notebooks/pull/22

darellkoh commented 5 years ago

Is this issue still open? It seems like there's already a PR for it but it wasn't clear that it had been claimed.

cuducos commented 5 years ago

Is this issue still open? It seems like there's already a PR for it but it wasn't clear that it had been claimed.

Yes. #20 and #22 were closed because they were overcomplicating stuff and @JinnaBalu was insisting in stuff maintainers agreed not to incorporate (such as deploy, Docker registry and tag). The idea is to KISS just to allow users to quickly get started.

jtemporal commented 5 years ago

@darellkoh this issue is yours if you still want it ;) looking forward for your PR :)

darellkoh commented 5 years ago

@jtemporal I do! I have the PR ready on a branch but I'm experiencing auth issues with being able to push to the remote. Looking into that now. Apologies in advance, I'm a first-time contributor.

cuducos commented 5 years ago

I'm experiencing auth issues with being able to push to the remote. Looking into that now. Apologies in advance, I'm a first-time contributor.

No need to apologise <3 Can you double check if you're trying to git push to your fork and not to our remote branch? As you do not have write permission to this repo, the best way would be to fork it and git push to the fork in your account. From there you can open a pull request to this repository here ; )

Let me know if this was helpful (and sorry if you already knew all that in advance)

darellkoh commented 5 years ago

@cuducos That definitely fixed it! Thanks for being patient <3 I've made the PR here: https://github.com/okfn-brasil/notebooks/pull/23.

Please feel free to point out if I'm missing anything, thanks so much.

jtemporal commented 5 years ago

closed by #23 thanks @darellkoh for the contribution :heart: