Unit test Chambers Of Deputies

[lipemorais]

Status It's Done for me.

What is the purpose of this Pull Request? The purpose of this PR is have 100% of coverage on chambers of deputies dataset.

What was done to achieve this purpose? I added unit test for it under tests/unit/chambers_of_deputies and used some fixtures to help.

How to test if it really works? To test if it really work you can use: python -m unittest discover tests/unit/chambers_of_deputies

Who can help reviewing it? @Irio @cuducos @jtemporal @anaschwendler could help with this PR.

TODO

• [x] Read the file before and after translation to test if it happened as expected
• [ ] Make it more functional avoiding too much IO and having more pure functions.
• [x] Improve clean testing time
• [x] Improve translate testing time
• [x] Use os.path.join for paths

[lipemorais]

I believe that the second point is a refactoring that might be in a different PR because would be too much for this one. Simple is better than complex. :+1:

[coveralls]

Coverage increased (+0.3%) to 85.667% when pulling 998825e58008138915862e56e83aebe7b8691858 on lipemorais:unit-test-chambers into 32ec5c1975b50580406feda31585bd4ffa5502ab on datasciencebr:master.

[lipemorais]

@jtemporal @anaschwendler @Irio @cuducos @cabral Is there any point that need to be improved before have it able to be merged?

[lipemorais]

Today this PR completes 22 days open. :'(

[coveralls]

Coverage increased (+9.2%) to 57.426% when pulling f0151bb50eb14b25d1bba30d3d99db36fc667f47 on lipemorais:unit-test-chambers into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.

[coveralls]

Coverage increased (+37.3%) to 85.596% when pulling 1c68860ff1c4512dcc1f1525da6266fc75a7d335 on lipemorais:unit-test-chambers into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.

[coveralls]

Coverage increased (+37.4%) to 85.62% when pulling 9b9eacc1f440f986bdc66ab0808d1b2490b52f05 on lipemorais:unit-test-chambers into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.