okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Add option to update all the datasets #133

Closed vitorkusiaki closed 7 years ago

vitorkusiaki commented 7 years ago

This PR contains commits from #132, so please merge #132 first.

If the user wants to download all the datasets, even if they are already downloaded, he can pass an option --all to the command ./setup. Otherwise, only the missing datasets will be downloaded.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 48.419% when pulling 72d9319bc3dfb847c5b4185a9da9bca0bb002e93 on vitorkusiaki:dataset-all-update into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+37.3%) to 85.524% when pulling 0be2a16aefceb22d61ce25dccabf6ff0900b479f on vitorkusiaki:dataset-all-update into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.

jtemporal commented 7 years ago

Hey @vitorkusiaki thanks for this ;)

This is getting the same error as #132 waiting the restarted build to take a closer look into it. But as @cuducos said it doesn't seem related to the PR itself.

vitorkusiaki commented 7 years ago

@jtemporal @cuducos hello! It seems the build has passed and the error was not related to this PR. Is it ok now? Any improvement for me to do?

lipemorais commented 7 years ago

@vitorkusiaki, first some pending reviews need to be addressed on #132 before merge this one.

jtemporal commented 7 years ago

Hi! @vitorkusiaki liked this a lot! Thank you for this PR! As @lipemorais said earlier, I left a code review and am waiting for the changes on #132 😉

Once they are done we'll need to update your code, but I believe everything is okay here.

I tested this in two stages:

  1. Running the tests to see if everything is passing

    • creating a new branch locally: git checkout -b vitorkusiaki-dataset-all-update master
    • pulling the changes proposed in this PR: git pull https://github.com/vitorkusiaki/serenata-toolbox.git dataset-all-update
    • Running tests: python -m unittest discover tests/unit
  2. Since this PR will mostly benefit other repositories setups I used serenata-de-amor environment to test this:

    • Edited the requirements.txt in serenata-de-amor repository so it would install the toolbox from @vitorkusiaki fork by replacing serenata-toolbox with git+https://github.com/vitorkusiaki/serenata-toolbox.git@dataset-all-update
    • with serenata_de_amor environment activated, ran the setup which gave me the following error: screen shot 2017-08-25 at 8 25 19 pm
jtemporal commented 7 years ago

hey @vitorkusiaki good news! #132 was merged, why don't you go ahead and fix the conflicts here so we can merge this?

This will be awesome and will also free datasciencebr/serenata-de-amor#273 to be merged!

Let me know if I can do anything to help out 😉

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 58.416% when pulling 29c8271647258cf7a01825fe86988ee813772cef on vitorkusiaki:dataset-all-update into 3bb7358c889cbcb0e7ceca6e5bc64b200cce9231 on datasciencebr:master.

vitorkusiaki commented 7 years ago

Hello @jtemporal @lipemorais @cuducos! Sorry it took so long, but I managed to update this PR.

Take a look at the last commit and tell me what you think. The travis build is still failling, but the test that failed is from another file that it's not on this PR scope. Looking forward for your feedback!

Thanks

lipemorais commented 7 years ago

Hey, @vitorkusiaki! There are some conflicts here with master branch. Could you fix this so we will be able to merge.

vitorkusiaki commented 7 years ago

It was a version conflict. It is fixed, @lipemorais. Thanks, hadn't noticed.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 58.416% when pulling ba8250daa7dc883610b26500408f58efca950624 on vitorkusiaki:dataset-all-update into 6179a2e6f7846cc6f6d9765f81d1ba9b1ca7c616 on datasciencebr:master.