okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Build stages on travis #134

Closed lipemorais closed 7 years ago

lipemorais commented 7 years ago

What is the purpose of this Pull Request? The purpose of this is introduce Build Stages feature on the project to address #129

What was done to achieve this purpose? I edit the .travis.yml file to use this new feature.

How to test if it really works? Here we have a green build using this feature.

Who can help reviewing it? @Irio @cuducos @jtemporal @anaschwendler could help with this PR.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+37.2%) to 85.476% when pulling dc3456dba70ddc539c37c4bcca2cde1a52b9f57a on lipemorais:build-stages-on-travis into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.

anaschwendler commented 7 years ago

Tested the PR and it seems to be working, I look into the code, but didn't know what to judge, maybe @jtemporal can do that part.

To test this PR, I clonned the project and ran into terminal: python -m unittest discover tests

lipemorais commented 7 years ago

@anaschwendler would nice to try the same command coverage run -m unittest discover tests just to be completely sure. This command will run both, unit and journey tests.

jtemporal commented 7 years ago

would nice to try the same command coverage run -m unittest discover tests just to be completely sure

Running coverage run -m unittest discover tests only runs unit tests.

Same happens with python -m unittest discover tests.

Trying to figure out how to run both tests with coverage. Will get back here once I got anything worth sharing

jtemporal commented 7 years ago

@cuducos just figured out! Thanks btw ❤

@lipemorais we need to add a __init__.py to tests/journey :)

That will be enough to make both test suites run =)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+37.2%) to 85.476% when pulling 276d0a6c4678356946bf57cd467fec8f4217ec9d on lipemorais:build-stages-on-travis into d53d3f365d49dc2328ff83762be1328a932a1a0d on datasciencebr:master.

cuducos commented 7 years ago

Should we add a version bump or a [ci skip] here…? I'm not sure.

jtemporal commented 7 years ago

Should we add a version bump or a [ci skip] here…? I'm not sure.

Actually we a have a conflict here since #132 was merged before this one... If @lipemorais could go ahead and fix the conflicts by updating the version to 12.1.1 I'll merge this right away.

This also means that #137 will also need some conflict solving but will be much better when taking into consideration releases.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+28.2%) to 85.667% when pulling 5fdd055d69a0648b5fab3b22254bec5161d2b5e4 on lipemorais:build-stages-on-travis into 790f79ce3f8790607025fd225f01616bdfb54b8d on datasciencebr:master.