Closed lipemorais closed 7 years ago
Tested the PR and it seems to be working, I look into the code, but didn't know what to judge, maybe @jtemporal can do that part.
To test this PR, I clonned the project and ran into terminal: python -m unittest discover tests
@anaschwendler would nice to try the same command coverage run -m unittest discover tests
just to be completely sure. This command will run both, unit and journey tests.
would nice to try the same command coverage run -m unittest discover tests just to be completely sure
Running coverage run -m unittest discover tests
only runs unit tests.
Same happens with python -m unittest discover tests
.
Trying to figure out how to run both tests with coverage
. Will get back here once I got anything worth sharing
@cuducos just figured out! Thanks btw ❤
@lipemorais we need to add a __init__.py
to tests/journey
:)
That will be enough to make both test suites run =)
Should we add a version bump or a [ci skip]
here…? I'm not sure.
Should we add a version bump or a
[ci skip]
here…? I'm not sure.
Actually we a have a conflict here since #132 was merged before this one... If @lipemorais could go ahead and fix the conflicts by updating the version to 12.1.1
I'll merge this right away.
This also means that #137 will also need some conflict solving but will be much better when taking into consideration releases.
What is the purpose of this Pull Request? The purpose of this is introduce Build Stages feature on the project to address #129
What was done to achieve this purpose? I edit the
.travis.yml
file to use this new feature.How to test if it really works? Here we have a green build using this feature.
Who can help reviewing it? @Irio @cuducos @jtemporal @anaschwendler could help with this PR.