okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Deployment ideas #135

Closed jtemporal closed 7 years ago

jtemporal commented 7 years ago

With #134 almost good to merge, I would like to raise a question already raised here and described bellow.

Today our deploys to PyPI are made whenever a PR is merged into master. And that's pretty good!

Though there's a catch: PRs that do not have version bump break our build because PyPI don't accept file upload with a same version. Hence breaking our Travis Build.

There are a few approaches and I would like to get some thoughts on:

1. create a release branch:

2. everything is at least a patch bump:

3. use the condition tag on deploy:

jtemporal commented 7 years ago

I like a lot the idea 2. =)

anaschwendler commented 7 years ago

I'm tending to prefer the second idea, too :)

cuducos commented 7 years ago

I think we are good with the 2nd… closing by inactivity then ; )