search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Fix float convertion #141

Closed cuducos closed 7 years ago

cuducos commented 7 years ago

This fixes a float conversion that was passing unnoticed and breaking Rosie.

This is how I tested it.

In the toolbox environment:

  1. Changed to (or create) cuducos-fix-float-convertion branch
  2. Pull the commits from this PR

In Rosie's environment:

  1. Uninstalled the current version of the toolbox: $ pip uninstall serenata_toolbox
  2. Install my local toolbox instead: $ pip install -e <path to serenata_toolbox>
  3. Run Rosie: $ python rosie.py run chamber_of_deputies ../serenata-de-amor/research/data

Important: I'm not sure this PR is really working, I believe it is because it goes further the point @jtemporal reported, however it throws an error typical of memory error… so I can't be sure.

jtemporal commented 7 years ago

@cuducos This looks good! version bump?

cuducos commented 7 years ago

I've done it in bf526ff but something got into master first. So… d03bc6b ; )

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 85.9% when pulling d03bc6b76b0a254f5e5ca81efc79011d2b39c9ad on cuducos-fix-float-convertion into bc316958e3de587d2f72b1f4c0a3ad0bcf9878f5 on master.

cuducos commented 7 years ago

Regarding the error I got it's this error. And this is the status of my hardware moments before crashing:

untitled
cuducos commented 7 years ago

Closed in favor of #144