search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Add PyPI label to README.rst #149

Closed marius92mc closed 7 years ago

marius92mc commented 7 years ago

What is the purpose of this Pull Request? Fixes https://github.com/datasciencebr/serenata-toolbox/issues/148.

What was done to achieve this purpose? Add a URL to the mentioned label.

How to test if it really works? See README.rst.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 58.278% when pulling 7e8e2dcba442a3d67b35089a6de29aab51100606 on marius92mc:add-pypi-label-to-readme into 3bb7358c889cbcb0e7ceca6e5bc64b200cce9231 on datasciencebr:master.

marius92mc commented 7 years ago

Should this be merged in this state knowing the coverage remained at that rate, @giovanisleite?

giovanisleite commented 7 years ago

Should this be merged in this state knowing the coverage remained at that rate, @giovanisleite?

Yes, the coverage and the travis error are not related to this issue.

I don't know if it is necessary to bump the version, but @jtemporal can tell you.

marius92mc commented 7 years ago

Yeah, I also think it is not needed to bump the version.

giovanisleite commented 7 years ago

Yeah we are trying to have a at least a minor bump version for any change in this project. :)

Actually, the readme/documentation is part of the project, so.. i think it is

marius92mc commented 7 years ago

Alright, @giovanisleite, I bumped the version.

cuducos commented 7 years ago

Regarding the version bump issue, it's written in the README.md:

Always suggest a version bump.

Always. Because every new code merged into master triggers the CI. And then the CI triggers a new release to PyPI. And this would ruin the whole project (omg I'm so dramatic…) hahaha… anyway, no, that's not a big big problem. But it's important to understand that not bumping the version will break something, and it's also important to understand why it breaks something.

So unless you add [skip ci] to your commit message, yes, bumping version is required ; )

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 58.278% when pulling 522cac4dab81004ead70c3e7edf2792559f79114 on marius92mc:add-pypi-label-to-readme into 3bb7358c889cbcb0e7ceca6e5bc64b200cce9231 on datasciencebr:master.