search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Fix README.rst mal formatted lines #161

Closed cuducos closed 6 years ago

cuducos commented 6 years ago

What is the problem?

Some code blocks are not formatted as expected:

pasted_image_29_11_17_15_32

How can this be addressed?

Checking reStructuredText syntax.

Who could help with this issue?

Anyone interested I guess ; )

ghost commented 6 years ago

Hi there! First-timer here, I cloned the repo, created branch for this issue, fixed those two block and I commited the changes. How do I push it to your repo? Sorry for noobie question but it's my first commit to a project which isn't mine :)

anaschwendler commented 6 years ago

Hi @Zubru22, welcome to our project!

There is totally no problem in asking, we are here to help!

You can read more about opening a PR (the way to push it to the repo) here.

To open a PR to our project you must change it to a new branch:

$ git checkout -b new-stuff

And push the content to the branch of your fork:

$ git push origin new-stuff

And then you can open a Pull Request to our repo :)

ghost commented 6 years ago

@anaschwendler, I'm glad I could help even with something as trivial as fixing readme. Commiting to a project always seemed scary to me. I figured it out that I need to fork your project, push it to my fork and then create pull request. Already done it. Thanks :)

anaschwendler commented 6 years ago

Thanks for your contribution @Zubru22!

I hope that this is a start to more PRs \o\ I didn't know how to contribute to open source before the project, and the idea is to bring more people, so feel welcome to see, if you want to, the other issues :)

I'll take a look at your PR later, but thanks! 🎉

anaschwendler commented 6 years ago

Closed by #164