search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Fixed missing pre formated tags #164

Closed ghost closed 6 years ago

ghost commented 6 years ago

I think those two tags should work now :)

cuducos commented 6 years ago

It's working beautifully @Zubru22 — many thanks 🎉

I'd kindly ask you to include a version bump. It's really important for us (more details in the last paragraphs of this section).

Just open setup.py and change version='12.3.0' by version='12.3.1' (as of today). Then commit, push to this branch and we're good to go ; )

ghost commented 6 years ago

Sorry, forgot to do it. It's done now, do I have to re-submit pull request? Or is it good to go?

anaschwendler commented 6 years ago

That is right @Zubru22, you're now good to go!

I'll wait for @cuducos merge the PR, since he started the review ;)

cuducos commented 6 years ago

Yay, many thanks @Zubru22 ; )

Just out of curiosity:

do I have to re-submit pull request? Or is it good to go?

The PR is based on the branch you created in your fork (in this case fix-readme). So any commit pushed to that branch and fork would automagically pop in here ; )