search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Fix log import bug #175

Closed cuducos closed 6 years ago

cuducos commented 6 years ago

What is the purpose of this Pull Request?

163 introduced a bug (#173) related to from serenata_toolbox import log. The problem was that the main module serenata_toolbox wasn't listed as a package in the setup.py.

What was done to achieve this purpose? I added serenata_toolbox as a package in setup.py

How to test if it really works?

  1. Fetch this branch
  2. Create a fresh new virtualenv
  3. Go to a different directory than the one you use to develop serenata-toolbox
  4. pip install <path to your serenata-toolbox directory>
  5. python -c 'from serenata_toolbox import log' should throw no errors

Who can help reviewing it? @anaschwendler @jtemporal

anaschwendler commented 6 years ago

Thanks @cuducos \o\

anaschwendler commented 6 years ago

Oh damn! We forgot the version bump again

cuducos commented 6 years ago

Oh damn! We forgot the version bump again

Either we did not or I'm going crazy.