163 introduced a bug (#173) related to from serenata_toolbox import log. The problem was that the main module serenata_toolbox wasn't listed as a package in the setup.py.
What was done to achieve this purpose?
I added serenata_toolbox as a package in setup.py
How to test if it really works?
Fetch this branch
Create a fresh new virtualenv
Go to a different directory than the one you use to develop serenata-toolbox
pip install <path to your serenata-toolbox directory>
python -c 'from serenata_toolbox import log' should throw no errors
Who can help reviewing it?
@anaschwendler @jtemporal
What is the purpose of this Pull Request?
163 introduced a bug (#173) related to
from serenata_toolbox import log
. The problem was that the main moduleserenata_toolbox
wasn't listed as a package in thesetup.py
.What was done to achieve this purpose? I added
serenata_toolbox
as a package insetup.py
How to test if it really works?
serenata-toolbox
pip install <path to your serenata-toolbox directory>
python -c 'from serenata_toolbox import log'
should throw no errorsWho can help reviewing it? @anaschwendler @jtemporal