search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Problem when downloading datasets from our servers #186

Closed anaschwendler closed 6 years ago

anaschwendler commented 6 years ago

This template is here to help you to write your issue ;)

What is the problem? Apparently, when you download the datasets from our servers, it still returns an error:

image

How can this be addressed? I seem that only by changing serenata-toolbox/datasets/remote.py line 57 for:

bucket=self.remote.BUCKET,

may work, but I recommend making a regression test for it.

Who could help with this issue? @cuducos may be the best because he was already working on it!

Labels [bug]

cuducos commented 6 years ago

Totally agree with the proposed solution. That's something I should have noticed myself and changed in #184. My bad, I missed it.

willianpaixao commented 6 years ago

@cuducos is this issue still occurring? I am unable to reproduce it.

cuducos commented 6 years ago

I don't think so. There are only 3 occurrences of bucket and if you're unable to reproduce it, I guess it is already fixed ; ) Tks