Closed cuducos closed 6 years ago
What I did to test this PR:
Clone the project
Change to @cuducos branch:
Run the python console, and tried to download one dataset
Try to see the content of the download and it returned an error:
➜ /tmp cat 2016-12-06-reimbursements.xz
<?xml version="1.0" encoding="UTF-8"?><Error><Code>NoSuchKey</Code><BucketName>serenata-de-amor-data</BucketName><RequestId>tx00000000000000002668d-005ab50a22-1632fc-nyc3a</RequestId><HostId>1632fc-nyc3a-nyc</HostId></Error>%
Many thanks for the review, @anaschwendler : )
Three minor changes:
NoSuchKey
anymoreWould you mind testing and reviewing it after these changes?
Ok! Now it is working! 🎉
Good one @cuducos \o\
This PR changes the datasets from Amazon S3 to Digital Ocean Spaces.
Following that change, a it added a bit of clean up:
Datasets.remote
objectIn spite of that it is flexible: when the envvar points to Digital Ocean Spaces, it works. If this envvar is not set it works with Amazon S3 right away.