Today @diilua warned me she was facing some issues installing the toolbox in Python 3.7. As far as I remember we haven't included Python 3.7 in setup.py because some third-party dependencies weren't compatible (probably something related to the new reserved keyword async). If I'm right, I think now this issue is gone and we can use the toolbox in Python 3.7.
What was done to achieve this purpose?
Added 3.7 as a supported Python version in setup.py and add it to Travis CI test suite.
How to test if it really works?
I installed my branch in a Python 3.7 virtualenv and tested the CLI with serenata-toolbox --module chamber_of_deputies data --year 2019. To be honest I haven't tested other apps.
Who can help reviewing it?
@sergiomario @diilua
TODO
In this PR I would like to wait to see if Travis works with the edits on .travis.yml
It think that in another PR we could use tox to run tests in two different Python versions (3.6 and 3.7) – once we merge this we can create a proper issue for that
My previous strategy didn't work, so I need to find a new way for Travis to run tests in Python 3.6 and 3.7. Any ideas?
What is the purpose of this Pull Request?
Today @diilua warned me she was facing some issues installing the toolbox in Python 3.7. As far as I remember we haven't included Python 3.7 in
setup.pybecause some third-party dependencies weren't compatible (probably something related to the new reserved keywordasync). If I'm right, I think now this issue is gone and we can use the toolbox in Python 3.7.What was done to achieve this purpose?
Added 3.7 as a supported Python version in
setup.pyand add it to Travis CI test suite.How to test if it really works?
I installed my branch in a Python 3.7 virtualenv and tested the CLI with
serenata-toolbox --module chamber_of_deputies data --year 2019. To be honest I haven't tested other apps.Who can help reviewing it? @sergiomario @diilua
TODO
In this PR I would like to wait to see if Travis works with the edits on.travis.ymlIt think that in another PR we could usetoxto run tests in two different Python versions (3.6 and 3.7) – once we merge this we can create a proper issue for thatMy previous strategy didn't work, so I need to find a new way for Travis to run tests in Python 3.6 and 3.7. Any ideas?