search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

We need to catch an HTTP error early in new years #221

Open cuducos opened 4 years ago

cuducos commented 4 years ago

At this point:

https://github.com/okfn-brasil/serenata-toolbox/blob/73efa9401cb562be2b8f7df74b49aee25727e181/serenata_toolbox/chamber_of_deputies/reimbursements.py#L35

We need a solution such as @luizfzs made in https://github.com/okfn-brasil/serenata-de-amor/pull/510 -- since in the first days of the year, the toolbox might try to find the dataset for the current year (which might be still unpublished).

luizfzs commented 4 years ago

To be honest, I started the fix on the toolbox but I was wondering that it would be an over-engineered solution, even though it's simple-ish, so I fixed it directly on Rosie. I can definitely create the PR for the fix on the toolbox, but it will require a new change on Rosie to make the exception handling compatible.

cuducos commented 4 years ago

To be honest, I started the fix on the toolbox but I was wondering that it would be an over-engineered solution, even though it's simple-ish, so I fixed it directly on Rosie.

Good point, you got me, @luizfzs!

I'll leave the issue open on the discretion of the current maintainers, but I personally rest my case -- especially because the Chamber of Deputies adapter runs year by year... it might worth it to leave the error explicitly at this stage.