search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Add timeout or similar to Downloader #42

Closed jtemporal closed 6 years ago

jtemporal commented 7 years ago

In case the download of one or more dataset is stuck we need to have a timeout or some other sort of breaking the wait gracefully.

arioston commented 7 years ago

Hi,

What you need is a simple timeout and an error message or need something more elaborate ?

Remove "timeout=None" will make the connection use default timeout, this is one solution.

cuducos commented 7 years ago

I think the best approach wouldn't be to simply remove this timeout=None. Instead I'd say that we user instantiate Dataset they could use a kwarg to customize it if they want. If they don't pass we assume it to be None. What do you think?

cuducos commented 6 years ago

Closed by #160