search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Fix namespace #44

Closed jtemporal closed 7 years ago

jtemporal commented 7 years ago

this PR should close #43

cuducos commented 7 years ago

I understand the theory underneath #43 but is there a more pragmatic use case exemplifying this issue? I ask that because maybe this fix changes the public API of the package — and that would not be a minor version bump…

jtemporal commented 7 years ago

Okay, so

maybe this fix changes the public API of the package — and that would not be a minor version bump

It does not.

Before this alteration, if you run any setup that needs the toolbox you get the following error: photo_2017-04-26_14-09-53 because there is a failure in the namespace so, basically Python was ignoring the datasets submodule.

with that correction everything will be back on track.

jtemporal commented 7 years ago

thank you @rodolfo-viana for catching this today ;)

cuducos commented 7 years ago

It does not.

🎉

rodolfo-viana commented 7 years ago

thank you @rodolfo-viana for catching this today ;)

<3