search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

Missing version bump #50

Closed jtemporal closed 7 years ago

jtemporal commented 7 years ago

We missed a version bumps when merging #48 and #49

Suggestions for version bump:

48 - micro - typo fix, not much trouble there

49 - micro - few renaming conventions based on the changes from CEAP to Chamber of Deputies

cuducos commented 7 years ago

Sorry, my bad. I'm not used to it yet. New PR bumping it twice sounds good? I'm gonna double check if changing the public API (renaming stuff) is a minor change though…

jtemporal commented 7 years ago

@cuducos that's my idea! check it and we can discuss it =)

New PR bumping it twice sounds good?

Yes! o/

cuducos commented 7 years ago

@cuducos that's my idea! check it and we can discuss it =)

I think that if the public API changes, it's a major version bump (I expanded I in the relevant topic.

jtemporal commented 7 years ago

Closing this in favor of #51