search

okfn-brasil / serenata-toolbox

📦 pip module containing code shared across Serenata de Amor's projects | ** Este repositório não recebe atualizações frequentes **
MIT License
154 stars 69 forks source link

add zip_safe=False to setup.py #56

Closed luzfcb closed 7 years ago

luzfcb commented 7 years ago

The zip_safe flag can be used to force or prevent zip Archive creation. In general you probably don’t want your packages to be installed as zip files because some tools do not support them and they make debugging a lot harder.

To maintain sanity, this flag should be included in all the setup.py files of all datasciencebr python packages .

cuducos commented 7 years ago

Great! Would mind bumping version before merging? Probably a minor change ; )

cuducos commented 7 years ago

Many thanks ; )

luzfcb commented 7 years ago

It may also be necessary to include include_package_data=True. include_package_data tells setuptools to look for a MANIFEST.in file and install all the entries that match as package data.

This is used to control exactly the files that setuptools includes in the generated package and when installing

django has a good MANIFEST.in example

cuducos commented 7 years ago

Is this an issue for another PR or are you planning to bringing it in in this one? If that's the case I'll label it as WIP (work in progress) and you can work on that with no hurry ; )

luzfcb commented 7 years ago

@cuducos include_package_data=True is a problem to another pull-request.

I found zip_safe=False error when try to solve serenata-toolbox incompatibility with dependency_links option of setup.py when I was making questions to setuptools / pip developers, to solve some things in https://github.com/datasciencebr/rosie/pull/44