search

okfn-brasil / vitimas-da-intolerancia

Conheça as vítimas de ódio político
https://vitimasdaintolerancia.org/
GNU Lesser General Public License v3.0
101 stars 10 forks source link

adding social share buttons #33

Closed ellisonleao closed 5 years ago

ellisonleao commented 6 years ago

ref #17

cuducos commented 6 years ago

Hi @ellisonleao – many thanks for the PR. But I think this is not exactly what #17 suggested:

After creating the button, it shares a short sentence about the project, website URL and hashtag #VítimasDaIntolerância.

You PR adds the share buttons per story, sharing the story's URL, not the project URL with it's own description. Following that we might not need a per story/case set of share buttons, but a single set on the header, or maybe before/after the list of cases, or yet in the footer…

What do you think about it?

ellisonleao commented 6 years ago

Oh sorry, i thought we were adding sharing buttons per story along with the project's hashtag. Do you prefer just a set of social share links on the footer then? Also, do you have any preferred sentence to be added as the share text?

cuducos commented 6 years ago

Worry not : ) As we pick up the main story randomly, I wouldn't share the link to one story. It might be better to create a URL per case and share the case URL listing all stories… but this is a topic for another/issue PR I guess.

Regarding the short description,I think it could be something we already use, such as Conheça os ataques motivados por intolerância política ; )

turicas commented 6 years ago

If we're going to put share buttons I vote to share the case, not a specific story about it.

ellisonleao commented 6 years ago

@cuducos @turicas what about adding a new url for the case with all the stories related to it for and use that new url on the share buttons?

something like:

/case/:slug or just /:slug

If we're going to put share buttons I vote to share the case, not a specific story about it.

that is the current behaviour no? i've added the case.main_story.url as the share link

cuducos commented 6 years ago

what about adding a new url for the case with all the stories related to it for and use that new url on the share buttons?

I like the idea, and I'd go for /:slug for the sake of simplicity ; )

that is the current behaviour no? i've added the case.main_story.url as the share link

case.main_story.url is the URL of the main story (which isn't actually main, it's just one of the stories randomly pick from the pile; so I wouldn't give even more spotlight to it).

turicas commented 6 years ago

+1 for having a page for each case in /:slug.

ellisonleao commented 6 years ago

i can do that. Should we open a new issue for it?

cuducos commented 6 years ago

i can do that. Should we open a new issue for it?

It might be recommended, but I'm fine reviewing it here if it comes with a nice commit history and nice commit messages : )

ellisonleao commented 6 years ago

@cuducos @turicas about the single page for case and their stories, what should we use as slug since the actual case doesn't have any field like a title?