Open cuducos opened 5 years ago
Update
With f12bd71c1365bf4231850da37c3bcce58b70755c we're already using GitHub Pages. I've updated the DNS and http://www.vitimasdaintolerancia.org/ is already being served by GitHub.
Disclaimer
First I tried @netlify, but as they do not support Python 3.7 and as we use dataclasses
(only available — natively — in Python 3.7) and as they do not support Pipenv, I decided to give GitHub Pages a try. Although I was unable to remove @netlify checks from this repository. What I've try:
HEAD
and forced a git push
to trigger a new buildBut stills… Netlify is running FIVE checks on this pull request. Any ideas how to remove these checks as we're not using @netlify anymore?
Now every check is gone, including Travis and Code Climate. Aff.
Todo
I think that if this PR is approved and merged we can close:
@cuducos I've checked the static content generation template and it looks okay. But, I have a question, you implemented static generation in Flask because the framework API is similar to Sanic, right?
I asked because I see simpler implementations with pelican, for example. But I think you should have chosen to keep an architecture similar to that drawn with Sanic.
Good point. I think there is a two-fold advantage in using this strategy (i.e. Flask + Freeze):
asyncio
fork of Flask), it was easy to transform it in a static site generator without bordering about adapting the whole architecture to Pelican's architecture;Procfile
to spin it up at Heroku again
This PR focuses on simplifying the production stack needed to deploy this web site: instead of a Python back-end and Redis, the proposal is to switch to a static site generator. Code reviewing this PR could be troublesome because there's a lot of changes, but the summary is:
asyncio
web framework (a574bad)Dockerfile
(7577ff5)If this looks like a good approach, one it's on
master
I can try to set it up on Netlify or GitHub pages, for example.When code reviewing I suggest two (non-exclusive) strategies: first is to review commit by commit to focus on smaller sets of changes; second, to follow the instructions on the updated version of the
README.md
.