Use target=_blank on stories urls

okfn-brasil / vitimas-da-intolerancia

Conheça as vítimas de ódio político

https://vitimasdaintolerancia.org/

GNU Lesser General Public License v3.0

101 stars 10 forks source link

Use target=_blank on stories urls #9

Closed ellisonleao closed 5 years ago

ellisonleao commented 6 years ago

https://github.com/okfn-brasil/violencia-nao-tem-partido/blob/master/violence/templates/index.html#L32

Maybe we can add _blank targets on links for a better user experience

cuducos commented 6 years ago

I'm like a dinosaur who remembers that W3C would recommend to not use target=_blank. The rational was:

Without target=_blank users would be a able in a ideal world to choose between opening the link in the same window, in a different tab or even in a different window (combining Shifts, Cmds and Alts with the click)
With target=_blank users have no choice

Not sure how update this recommendation is. What do you think about it?

ellisonleao commented 6 years ago

I think the only "recommendation" for use _blank targets are for when your link points to another website. But then again, this is totally a personal choice. There are several reasons for use it or not

kishan3 commented 6 years ago

https://github.com/okfn-brasil/violencia-nao-tem-partido/blob/master/violence/templates/index.html#L32

Maybe we can add _blank targets on links for a better user experience

The link is broken. 404 error

cuducos commented 6 years ago

We started using Jinja2 extends so we changed a bit the HTML files. But @ellisonleao was referring to external links to news outlet stories.