search

okfn / ckanclient-deprecated

DEPRECATED - please see https://github.com/ckan/ckanapi. [Python client library for CKAN]
http://pypi.python.org/pypi/ckanclient
25 stars 17 forks source link

Bugfix s3 upload #14

Closed glance- closed 11 years ago

glance- commented 11 years ago

Bugfix and restructure some code so ckanclient can be used to upload data-files to s3.

metaodi commented 11 years ago

For me this PR works perfectly :+1: . Would be great if it gets merged soon :wink:

amercader commented 11 years ago

@rgrp You are probably the one with more experience to check this

rufuspollock commented 11 years ago

@glance- if you had any additional tests for this it would be great but we'll merge this right now (sorry for the delay!)

glance- commented 11 years ago

Thanks for merging this fixes.

Nope, i didn't write any integration/unittests, i just tested it against a real installation.

All the patches are quite trivial, and quite well broken down so they should be quite easy to review to see that they are doing the right ting.

I'm currently off to working on other non-ckan projects, but ill try to remember to revisit this one when/if i end up doing some more ckan-work.

glance- commented 11 years ago

This never got merged? or did it get force-pushed out of repo?

rufuspollock commented 11 years ago

Hmmm, i thought it got merged but somehow it seems not to. Any way you can resubmit - sorry about this!