Workaround for missing/wrong URL from pull request #19

okfn / ckanclient-deprecated

DEPRECATED - please see https://github.com/ckan/ckanapi. [Python client library for CKAN]

http://pypi.python.org/pypi/ckanclient

25 stars 17 forks source link

Workaround for missing/wrong URL from pull request #19 #20

Closed hbunke closed 11 years ago

hbunke commented 11 years ago

urllib2 refused to open URL submitted by _post_multipart. Caused by replacing httplib. This is 'quick'n'dirty'. Fileupload, e.g. _post_multipart should use the same methods as any other request, so APIRequest should implement this.

rufuspollock commented 11 years ago

@hbunke any thoughts on getting in some simple tests - may make it easy to enhance and refactor.

hbunke commented 11 years ago

@rgrp Yes, you're absolutely right. I considered my fixes to be too small for tests, but that's never a good argument ;-) And there seem to be no tests at all for file upload methods at the moment, so it would make sense anyway. I'll try when I have some time.