search

okfn / ckanext-collaborators

User-level permissions for CKAN datasets for CKAN < 2.9
GNU Affero General Public License v3.0
5 stars 2 forks source link

Editor collaborator forces change of owner organization on dataset update #11

Open pdekraker-epa opened 4 years ago

pdekraker-epa commented 4 years ago

Enabling an editor collaborator enables write access to all dataset properties. This includes the owner organization, and if using the web UI the collaborator (who does not belong to the owner org) cannot maintain the dataset's connection to the owner org as it is not an option on the form.

One initial change would be to hide/disable the owner org on the dataset form. I would also argue that changing visibility should be restricted to owner editors as well (perhaps this could be configurable). Limiting access in the API is another matter.

amercader commented 4 years ago

Thanks for the report @pdekraker-epa . Without having look at this, I would expect that collaborators should only see the owner org field if they were members of an another organization (and so they could assign the dataset to it). Is that not the case? eg a user who is not a member of any organization can edit this field? If so I agree this is something it needs to be fixed