#55 Fixes resource template to have action buttons non-duplicated

okfn / ckanext-pdeu

Custom CKAN Extension for PublicData.eu

9 stars 4 forks source link

#55 Fixes resource template to have action buttons non-duplicated #59

Closed johnmartin closed 11 years ago

johnmartin commented 11 years ago

Fixes #55

The change looks scary. It isn't really. It's because of the lack of blocks in the parent template. See for context: https://github.com/okfn/ckan/blob/master/ckan/templates/package/resource_read.html

joetsoi commented 11 years ago

I'm happy to merge this now, but it'd be nicer to add a block in between div.actions in ckan and then override that here, just to eliminate the duplication

I'll merge this and create a pull request in ckan to create an action block and keep an issue open and then I'll fix it up once it's done. Sound sensible? I hate leaving issues lying around and I'm not sure I want to add more noise to the ckan "pull requests/this needs to be in 2.0" queue.

johnmartin commented 11 years ago

@joetsoi Great minds think alike: https://github.com/okfn/ckan/pull/704/files#L30R19 (so no need to create another pull request)