okfn / ckanext-pdeu

Custom CKAN Extension for PublicData.eu
9 stars 4 forks source link

Migrate publicdata.eu's "Apps & Ideas" extension to CKAN's builtin "related" feature #6

Closed seanh closed 12 years ago

seanh commented 12 years ago

Apparently the related feature also provides a site-wide 'app marketplace' similar to what publicdata.eu's apps & ideas extension does? I hadn't realised. Need to look into this

seanh commented 12 years ago

I've done this except that I still need to migrate the images from ckanext-apps

seanh commented 12 years ago

@johnmartin I've added the image files for the related applications to this git repo. To see them you need to clear the related items from your database and then reload them. Assuming the database you're using is called pdeu and the CKAN ini file you're using for pdeu dev is called pdeu.ini:

sudo -u postgres psql -d pdeu -c "DELETE FROM related;"
paster ckanext-apps-migrate -c ../ckan/pdeu.ini load related.json

There are no images for the related ideas, so you might want to do something different with the styling of those.

seanh commented 12 years ago

@johnmartin Assigning this to you as I think it's done apart from any design work you want to do on it

johnmartin commented 12 years ago

@seanh I've just pushed some styling tweaks for the homepage. The featured area is should be nice now. I wasn't able to test it on real data... because I couldn't get that paster command to work. However I just tested against standard related items from my own DB (just removed the mask for featured in the controller to test)

Take a look and then let's close this ticket.

seanh commented 12 years ago

@johnmartin What was your problem getting the paster command to work? Maybe follow the latest instructions at https://github.com/okfn/ckanext-pdeu because they changed, you need to install ckanext-apps and run the command from the ckanext-apps dir.

The "View larger map" link is not clickable for me, is that a problem on my end?

Otherwise it seems to be working although there's still a problem with the Related Ideas that they contain h1's in their descriptions (when data is loaded with the paster command), I'll try to see why that's happening.

Another issue when the real data is loaded is that some of the apps and ideas have very long descriptions, so when you click the "show more" link the popup is very long and goes way off the bottom of the site.

seanh commented 12 years ago

Otherwise it seems to be working although there's still a problem with the Related Ideas that they contain h1's in their descriptions (when data is loaded with the paster command), I'll try to see why that's happening.

Another issue when the real data is loaded is that some of the apps and ideas have very long descriptions, so when you click the "show more" link the popup is very long and goes way off the bottom of the site.

A simple template tweak fixed both of these, use h.markdown_extract() instead of h.render_markdown() for related item descriptions. Maybe this tweak should be in CKAN core?

So the only problem I still have is the view map link not working

seanh commented 12 years ago

Oops, view larger map is not relevant to this ticket, closing this ticket then