okfn / ckanext-showcase

[WIP] A ckan extension to showcase datasets in use
GNU Affero General Public License v3.0
2 stars 1 forks source link

[WIP] Change dataset type to be a story #7

Closed roll closed 6 years ago

roll commented 6 years ago
roll commented 6 years ago

For now, we get errors like below (e.g. on search/list).

And in general, it seems to change DATASET_TYPE_NAME doesn't really works properly. I still get showcase redirects on creation etc.

ckan-dev_1    | Error - <class 'routes.util.GenerationException'>: url_for can only return a string, got unicode instead: showcase_read?action=read&controller=package&id=map
ckan-dev_1    | URL: http://ckan-dev:5000/dataset
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/weberror/errormiddleware.py', line 171 in __call__
ckan-dev_1    |   app_iter = self.application(environ, sr_checker)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
ckan-dev_1    |   resp = self.call_func(req, *args, **self.kwargs)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
ckan-dev_1    |   return self.func(req, *args, **kwargs)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/fanstatic/publisher.py', line 234 in __call__
ckan-dev_1    |   return request.get_response(self.app)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
ckan-dev_1    |   application, catch_exc_info=False)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
ckan-dev_1    |   app_iter = application(self.environ, start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
ckan-dev_1    |   resp = self.call_func(req, *args, **self.kwargs)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
ckan-dev_1    |   return self.func(req, *args, **kwargs)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/fanstatic/injector.py', line 54 in __call__
ckan-dev_1    |   response = request.get_response(self.app)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
ckan-dev_1    |   application, catch_exc_info=False)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
ckan-dev_1    |   app_iter = application(self.environ, start_response)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/config/middleware/pylons_app.py', line 265 in inner
ckan-dev_1    |   result = application(environ, start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/beaker/middleware.py', line 73 in __call__
ckan-dev_1    |   return self.app(environ, start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/beaker/middleware.py', line 156 in __call__
ckan-dev_1    |   return self.wrap_app(environ, session_start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/routes/middleware.py', line 131 in __call__
ckan-dev_1    |   response = self.app(environ, start_response)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/config/middleware/common_middleware.py', line 30 in __call__
ckan-dev_1    |   return self.app(environ, start_response)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/config/middleware/common_middleware.py', line 56 in __call__
ckan-dev_1    |   return self.app(environ, start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/wsgiapp.py', line 125 in __call__
ckan-dev_1    |   response = self.dispatch(controller, environ, start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/wsgiapp.py', line 324 in dispatch
ckan-dev_1    |   return controller(environ, start_response)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 240 in __call__
ckan-dev_1    |   res = WSGIController.__call__(self, environ, start_response)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/controllers/core.py', line 221 in __call__
ckan-dev_1    |   response = self._dispatch_call()
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/controllers/core.py', line 172 in _dispatch_call
ckan-dev_1    |   response = self._inspect_call(func)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/controllers/core.py', line 107 in _inspect_call
ckan-dev_1    |   result = self._perform_call(func, args)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/controllers/core.py', line 60 in _perform_call
ckan-dev_1    |   return func(**args)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/controllers/package.py', line 332 in search
ckan-dev_1    |   extra_vars={'dataset_type': package_type})
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 125 in render
ckan-dev_1    |   return cached_template(template_name, renderer)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/templating.py', line 249 in cached_template
ckan-dev_1    |   return render_func()
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 162 in render_template
ckan-dev_1    |   return render_jinja2(template_name, globs)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 94 in render_jinja2
ckan-dev_1    |   return template.render(**extra_vars)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/jinja2/environment.py', line 989 in render
ckan-dev_1    |   return self.environment.handle_exception(exc_info, True)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/jinja2/environment.py', line 754 in handle_exception
ckan-dev_1    |   reraise(exc_type, exc_value, tb)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/package/search.html', line 2 in top-level template code
ckan-dev_1    |   {% import 'macros/form.html' as form %}
ckan-dev_1    | File '/srv/app/src_extensions/ckanext-lacounts/ckanext/lacounts/templates/page.html', line 1 in top-level template code
ckan-dev_1    |   {% ckan_extends %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/page.html', line 1 in top-level template code
ckan-dev_1    |   {% extends "base.html" %}
ckan-dev_1    | File '/srv/app/src_extensions/ckanext-geoview/ckanext/geoview/templates/base.html', line 1 in top-level template code
ckan-dev_1    |   {% ckan_extends %}
ckan-dev_1    | File '/srv/app/src/ckanext-googleanalytics/ckanext/googleanalytics/templates/base.html', line 1 in top-level template code
ckan-dev_1    |   {% ckan_extends %}
ckan-dev_1    | File '/srv/app/src/ckanext-harvest/ckanext/harvest/templates/base.html', line 1 in top-level template code
ckan-dev_1    |   {% ckan_extends %}
ckan-dev_1    | File '/srv/app/src_extensions/ckanext-lacounts/ckanext/lacounts/templates/base.html', line 1 in top-level template code
ckan-dev_1    |   {% ckan_extends %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/base.html', line 101 in top-level template code
ckan-dev_1    |   {%- block page %}{% endblock -%}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/page.html', line 19 in block "page"
ckan-dev_1    |   {%- block content %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/page.html', line 22 in block "content"
ckan-dev_1    |   {% block main_content %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/page.html', line 74 in block "main_content"
ckan-dev_1    |   {% block primary %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/page.html', line 87 in block "primary"
ckan-dev_1    |   {% block primary_content %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/package/search.html', line 37 in block "primary_content"
ckan-dev_1    |   {% block package_search_results_list %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/package/search.html', line 38 in block "package_search_results_list"
ckan-dev_1    |   {{ h.snippet('snippets/package_list.html', packages=c.page.items) }}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/helpers.py', line 1688 in snippet
ckan-dev_1    |   return base.render_snippet(template_name, **kw)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 84 in render_snippet
ckan-dev_1    |   output = render(template_name, extra_vars=kw)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 125 in render
ckan-dev_1    |   return cached_template(template_name, renderer)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/templating.py', line 249 in cached_template
ckan-dev_1    |   return render_func()
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 162 in render_template
ckan-dev_1    |   return render_jinja2(template_name, globs)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 94 in render_jinja2
ckan-dev_1    |   return template.render(**extra_vars)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/jinja2/environment.py', line 989 in render
ckan-dev_1    |   return self.environment.handle_exception(exc_info, True)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/jinja2/environment.py', line 754 in handle_exception
ckan-dev_1    |   reraise(exc_type, exc_value, tb)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_list.html', line 17 in top-level template code
ckan-dev_1    |   {% block package_list %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_list.html', line 20 in block "package_list"
ckan-dev_1    |   {% block package_list_inner %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_list.html', line 22 in block "package_list_inner"
ckan-dev_1    |   {% snippet 'snippets/package_item.html', package=package, item_class=item_class, hide_resources=hide_resources, banner=banner, truncate=truncate, truncate_title=truncate_title %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/jinja_extensions.py', line 268 in _call
ckan-dev_1    |   return base.render_snippet(args[0], **kwargs)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 84 in render_snippet
ckan-dev_1    |   output = render(template_name, extra_vars=kw)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 125 in render
ckan-dev_1    |   return cached_template(template_name, renderer)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/pylons/templating.py', line 249 in cached_template
ckan-dev_1    |   return render_func()
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 162 in render_template
ckan-dev_1    |   return render_jinja2(template_name, globs)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/base.py', line 94 in render_jinja2
ckan-dev_1    |   return template.render(**extra_vars)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/jinja2/environment.py', line 989 in render
ckan-dev_1    |   return self.environment.handle_exception(exc_info, True)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/jinja2/environment.py', line 754 in handle_exception
ckan-dev_1    |   reraise(exc_type, exc_value, tb)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_item.html', line 21 in top-level template code
ckan-dev_1    |   {% block package_item %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_item.html', line 23 in block "package_item"
ckan-dev_1    |   {% block content %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_item.html', line 25 in block "content"
ckan-dev_1    |   {% block heading %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_item.html', line 35 in block "heading"
ckan-dev_1    |   {% block heading_title %}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/templates/snippets/package_item.html', line 36 in block "heading_title"
ckan-dev_1    |   {{ h.link_to(h.truncate(title, truncate_title), h.url_for(package.type + '_read', controller='package', action='read', id=package.name)) }}
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/helpers.py', line 323 in url_for
ckan-dev_1    |   my_url = _url_for_pylons(*args, **kw)
ckan-dev_1    | File '/srv/app/src/ckan/ckan/lib/helpers.py', line 412 in _url_for_pylons
ckan-dev_1    |   return _routes_default_url_for(*args, **kw)
ckan-dev_1    | File '/usr/lib/python2.7/site-packages/routes/util.py', line 265 in url_for
ckan-dev_1    |   "unicode instead: %s" % url)
ckan-dev_1    | GenerationException: url_for can only return a string, got unicode instead: showcase_read?action=read&controller=package&id=map
roll commented 6 years ago

We will try another approach