okfn / docker-ckan

Docker images and Docker Compose setup for CKAN [Not Maintained]
GNU Affero General Public License v3.0
83 stars 91 forks source link

Missing double underscore in Dockerfile #90

Closed tristndev closed 2 years ago

tristndev commented 2 years ago

In the ckan-base/2.9/Dockerfile the variable CKAN_SITE_URL is introduced but never used. I reckon it is a typo and CKAN__SITE_URL is meant (note the double underscore). Fixed that for you.

amercader commented 2 years ago

thanks @tristndev , CKAN core itself supports the CKAN_SITE_URL env var, so that's why we use this variant here

tristndev commented 2 years ago

But further down (Line 79), the variable CKAN__SITE_URL with double underscore is used - where is this provided?

amercader commented 2 years ago

Aha! You are right, we should change line 79 to use CKAN_SITE_URL instead, or tbh just delete it as it obviously is not working as intended

tristndev commented 2 years ago

I have opened another pull request with your requested change here #91