search

okfn / docker-ckan

Docker images and Docker Compose setup for CKAN [Not Maintained]
GNU Affero General Public License v3.0
81 stars 88 forks source link

eval(response_from_solr)? #99

Closed wardi closed 1 year ago

wardi commented 1 year ago

Noticing an interesting error on startup:

[prerun] Initializing datastore db - end
b''
Traceback (most recent call last):
  File "/srv/app/prerun.py", line 203, in <module>
    check_solr_connection()
  File "/srv/app/prerun.py", line 85, in check_solr_connection
    eval(connection.read())
  File "<string>", line 8, in <module>
NameError: name 'true' is not defined

Which leads to https://github.com/okfn/docker-ckan/blob/dfa58c885795bcafe531bfe2e0289c53b6f203ea/ckan-base/master/setup/prerun.py#L85 a line that traces back to the first commit on the repo. I'm not sure what could be gained by evaluating a solr response as a python expression here.