[UP] Suggestion to fix issue 79 and 71

okfn / handbook

Guides and introductions for participating in Labs and some of its projects.

http://okfnlabs.org/handbook/

170 stars 51 forks source link

[UP] Suggestion to fix issue 79 and 71 #83

Closed gsilvapt closed 8 years ago

gsilvapt commented 8 years ago

Suggestion to fix issue 71 and 79

Right after push, got this email from GitHub about custom pages.

Never seen that so I thought it would be better to show you guys to make sure there is nothing wrong.

rufuspollock commented 8 years ago

Generally looks good.

Couple of items:

glossary is at /glossary/glossary.md surely this should be /glossary/index.md?
You have this in the commit which is surely accidental:
```
.Rhistory
```
To correct you need not only to remove but to "squash" the commits because we do not want this in the commit history if possible.

gsilvapt commented 8 years ago

I have no idea how that R temp file went over there. I haven't used R in a while!?

Anyway, I think I did everything correctly this time. Apologies for the lack of integrity there. Please let me know if I wasn't able to do it. I tried via terminal and it was just a huge mess but according to GitHub, it is worked.

Thank you for the feedback

rufuspollock commented 8 years ago

Great!. Looks good.