search

okfn / ibp-explorer

[ARCHIVED] Data Explorer for the Open Budget Survey, built in collaboration with the International Budget Partnership.
http://survey.internationalbudget.org
7 stars 5 forks source link

Merge tracker #103

Closed dumyan closed 7 years ago

dumyan commented 7 years ago

OLD Description:

This is the initial version of the tracker merging. There are couple of things to get fixed on the development and deployment side, because now we have one front-end app that gets build with webpack and it's statically served with express and another express app which uses bower for some deps and somewhat broken gulp setup for building and deploying.

Tried to partially overcome this by using webpack middleware with express but I couldn't get that working properly for today.

Things I think should get added:

This branch now includes various fixes for the API and client requests.

brew commented 7 years ago

I haven't done a thorough review of this branch, but have looked at each commit and nothing pops out. This code has been in production for several months now, and I'm happy to merge it into master. I have some Travis/Coverage fixes in a separate branch I'll merge later.