search

okfn / ibp-explorer

[ARCHIVED] Data Explorer for the Open Budget Survey, built in collaboration with the International Budget Partnership.
http://survey.internationalbudget.org
7 stars 5 forks source link

Some countries don't link to their respective gdrive directories #114

Closed brew closed 6 years ago

brew commented 7 years ago

This is the case where the country name on the website differs to that used as the directory name in gdrive:

Website GDrive
São Tomé e Príncipe Sao Tome e Principe
Moldova, Republic of Moldova
Dem. Rep. of Congo Democratic Republic of Congo
Côte d’Ivoire Cote d'Ivoire
Russia Russian Federation
South Korea South Korea*
Yemen Yemen*

*Included in the country override here: https://github.com/okfn/ibp-explorer/blob/09d14efbfd117b3870d5e1a10782e73220620a3c/routes/index.js#L48-L51

brew commented 7 years ago

Changing the gdrive names to reflect those used on the website will allow them to be matched correctly. In the case of those being overridden (South Korea and Yemen), the gdrive name should be that pre-override, namely "Korea, Republic of" and "Yemen, Rep.".

pwalsh commented 6 years ago

Assume changes done on side of the client.