okfn / messytables

Tools for parsing messy tabular data. This is now superseded by https://github.com/frictionlessdata/tabulator-py
http://messytables.readthedocs.io/
387 stars 110 forks source link

JSON Table Schema in MessyTables #135

Closed pwalsh closed 8 years ago

pwalsh commented 9 years ago

In light of https://github.com/mk270/json-table-schema-python/issues/4 and https://github.com/okfn/messytables/pull/131, I want to talk about about JSON Table Schema.

davidread commented 9 years ago

The question is, is there a reasonable chance of breaking changes affecting messytables? If so we should add an upper-limit on the json-table-schema version in setup.py, for the sake of future messytables releases.

pwalsh commented 9 years ago

@davidread there should be an upper-limit on json-table-schema in any event (and other deps., as I made the case for in #144).

For your question, in this case: yes, the new code is a completely different API.

I think the question is more, then, does anyone want to fix JTS support in the current version of messy tables? if yes, the effort should be made to support the new lib, which actually implements most of the spec, unlike the current dependency in messytables. If it is not important, then, I strongly suggest pinning the dependency at the last version of the old codebase.

I've been talking with @pudo about MT2 (ref. and ref.) and any code there would certainly use the new lib in any event.

pwalsh commented 8 years ago

Version has been pinned to the (very) old jts lib. We'd have to see more interest to make the changes required for the more up-to-date lib that OKI has. And, once @pudo brings in typecast it will probably be enough for the current use cases around messytables.